Skip to content

feat: Add werkzeug instrumentation and unittests#871

Merged
GSVarsha merged 1 commit into
mainfrom
werkzeug
May 15, 2026
Merged

feat: Add werkzeug instrumentation and unittests#871
GSVarsha merged 1 commit into
mainfrom
werkzeug

Conversation

@CagriYonca
Copy link
Copy Markdown
Contributor

@CagriYonca CagriYonca commented May 8, 2026 •
edited
Loading

Changed the middleware instrumentation to the monkey-patching approach as we use in other instrumentations.

$$ python-sensor % coverage report -m src/instana/instrumentation/werkzeug.py src/instana/instrumentation/wsgi.py src/instana/util/wsgi_utils.py 
Name                                      Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------
src/instana/instrumentation/werkzeug.py      31      0   100%
src/instana/instrumentation/wsgi.py          13      0   100%
src/instana/util/wsgi_utils.py               70      0   100%
-----------------------------------------------------------------------
TOTAL                                       114      0   100%

@CagriYonca CagriYonca self-assigned this May 8, 2026
@CagriYonca CagriYonca requested a review from a team as a code owner May 8, 2026 09:03
@CagriYonca CagriYonca force-pushed the werkzeug branch 2 times, most recently from c51cef4 to 2a8a1b1 Compare May 8, 2026 11:14
pvital
pvital requested changes May 11, 2026
View reviewed changes
Comment thread src/instana/instrumentation/werkzeug.py Outdated
Comment thread tests/apps/werkzeug_app/__init__.py Outdated
@CagriYonca CagriYonca marked this pull request as draft May 11, 2026 07:29
@CagriYonca CagriYonca force-pushed the werkzeug branch 6 times, most recently from 5e1fc9f to edb4117 Compare May 11, 2026 13:44
@CagriYonca CagriYonca marked this pull request as ready for review May 11, 2026 13:49
@CagriYonca CagriYonca requested a review from pvital May 11, 2026 13:49
pvital
pvital requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little requests.

Comment thread tests/util/__init__.py
Comment thread tests/instrumentation/__init__.py
@CagriYonca CagriYonca requested a review from pvital May 12, 2026 08:28
@CagriYonca CagriYonca force-pushed the werkzeug branch 3 times, most recently from d961757 to 68742fb Compare May 12, 2026 13:57
@CagriYonca CagriYonca requested a review from GSVarsha May 13, 2026 12:04
pvital
pvital approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

GSVarsha
GSVarsha reviewed May 14, 2026
View reviewed changes
Comment thread src/instana/util/wsgi_utils.py Outdated
GSVarsha
GSVarsha reviewed May 14, 2026
View reviewed changes
Comment thread src/instana/instrumentation/werkzeug.py Outdated
GSVarsha
GSVarsha reviewed May 14, 2026
View reviewed changes
Comment thread src/instana/instrumentation/werkzeug.py Outdated
GSVarsha
GSVarsha requested changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes here as well as in a thread

@CagriYonca CagriYonca force-pushed the werkzeug branch 2 times, most recently from 71c40d2 to 8da8808 Compare May 15, 2026 10:35
@CagriYonca CagriYonca requested a review from GSVarsha May 15, 2026 10:35
@CagriYonca
feat: Add werkzeug instrumentation and unittests
39be932 
Signed-off-by: Cagri Yonca <cagri@ibm.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 15, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

GSVarsha
GSVarsha approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@GSVarsha GSVarsha merged commit ecec084 into main May 15, 2026
20 checks passed
@GSVarsha GSVarsha deleted the werkzeug branch May 15, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes

@GSVarsha GSVarsha GSVarsha approved these changes

Assignees

@CagriYonca CagriYonca

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CagriYonca @pvital @GSVarsha