fix: only call _validate() when strict=True#2062
Open
dreamer0129 wants to merge 1 commit into
Open
Conversation
_validate() was called unconditionally, rejecting brp values > 64 even when strict=False. This is too restrictive for some peripherals like FYSETC UCAN which support brp up to 1024. Only call _validate() when strict=True, matching the behavior of _restrict_to_minimum_range(). Fixes hardbyte#2061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix BitTiming rejecting brp values > 64 even when
strict=False.Root Cause
self._validate()was called unconditionally in__init__, even whenstrict=False. The validation rejects brp values outside [1,64], which is too restrictive for peripherals like FYSETC UCAN that support brp up to 1024.Fix
Only call
_validate()whenstrict=True:This makes validation consistent - both and only run when
strict=True.Testing
With this fix, peripherals like FYSETC UCAN (candleLight firmware) can use brp > 64 without ValueError.
Closes #2061