feat(gooddata-sdk): [AUTO] Add ExecutionResultLimitBreak schema for partial results#1614
Closed
yenkins-admin wants to merge 3 commits into
Closed
feat(gooddata-sdk): [AUTO] Add ExecutionResultLimitBreak schema for partial results#1614yenkins-admin wants to merge 3 commits into
yenkins-admin wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
+ Coverage 79.01% 79.03% +0.02%
==========================================
Files 231 231
Lines 15619 15636 +17
==========================================
+ Hits 12341 12358 +17
Misses 3278 3278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added ExecutionResultLimitBreak SDK class and limit_breaks property on ExecutionResult. The new class models the ExecutionResultLimitBreak schema (limit, limit_type, value) with a from_dict() classmethod that maps camelCase API keys to snake_case fields. ExecutionResult now reads the optional limitBreaks list from the API response (stored as an additional property under its camelCase key) and exposes it as limit_breaks → list[ExecutionResultLimitBreak], returning [] when absent. The class is re-exported from gooddata_sdk.init.
Impact: new_feature | Services:
gooddata-afm-clientSource commits (gdc-nas):
71bb41aby Mike Zelenskij — Merge pull request #22984 from gooddata/c.mze-cq-2334Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_bare_execution_response.pypackages/gooddata-sdk/tests/compute/test_execution_result_limit_break.pypackages/gooddata-sdk/tests/compute/fixtures/.gitkeepAgent decisions
Decisions (3)
placement of limitBreaks on ExecutionResult vs ExecutionResultMetadata — Add limitBreaks as a field on ExecutionResult (the top-level result object)
accessing limitBreaks from undeclared model field — Use result.get('limitBreaks') with camelCase key on the ModelNormal instance
absent limitBreaks returns empty list vs None — Return [] when limitBreaks absent from API response
Assumptions to verify (3)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_bare_execution_response.pypackages/gooddata-sdk/tests/compute/test_execution_result_limit_break.pyOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow