Remove unsupported platforms from asmdef#2688
Closed
jzapdot wants to merge 1 commit into
Closed
Conversation
Removed unsupported platforms 'Lumin' and 'Stadia' from the assembly definition.
|
This PR has been automatically closed. All non-maintainer contributions must reference an existing GitHub issue. Next steps:
Please review our contributing guidelines for more details. |
Author
|
This PR addresses issue #2689. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest SDK
4.3.1doesn't compile for Unity6000.3.11f1when pulled from UPM. Instead:package/Editor/io.sentry.unity.editor.asmdefnot finding the runtime AssemblyDefinitionpackage/Editor/Runtime/io.sentry.unity.runtime.asmdef.package/Editor/Runtime/io.sentry.unity.runtime.asmdefdoesn't load in the editor. In the inspector it shows a warning for invalid platforms.I resolved these issues locally by customizing the package, removing the unsupported platforms, and toggling off the "Use Guids" checkbox on the
package/Editor/Runtime/io.sentry.unity.runtime.asmdefand manually assigning thepackage/Editor/Runtime/io.sentry.unity.runtime.asmdeffile.This PR:
I wasn't able to to determine why the package could not be assigned via guid. This is usually due to something being off with the meta guid assigned to the AsmDef and requires blowing away the meta and re-updating the AssemblyDefinition to have the original settings.