feat(core): Convert scope contexts to segment span attributes in span streaming#20828
Open
chargome wants to merge 4 commits into
Open
feat(core): Convert scope contexts to segment span attributes in span streaming#20828chargome wants to merge 4 commits into
chargome wants to merge 4 commits into
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b7285a8. Configure here.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JPeer264
approved these changes
May 13, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
Just one devils advocate comment
| } | ||
|
|
||
| // Framework version contexts | ||
| const angular = contexts['angular']; |
Member
There was a problem hiding this comment.
q: Does it make sense to have framework specific code in core? I'm fine with it, just challenging if we really want to do this.
Member
Author
There was a problem hiding this comment.
It basically syncs all context centrally that can make its way into browser sdks. But I do see your point obv
nicohrubec
approved these changes
May 13, 2026
Member
nicohrubec
left a comment
nicohrubec
left a comment
There was a problem hiding this comment.
lgtm if conventions are approved
Only consumed by the transaction-based processEvent profiling path, not by span streaming. The fallback uses the span's own start_timestamp. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyScopeToSegmentSpanin the captureSpan pipeline to convert known scopecontexts (set via
scope.setContext()) to segment span attributesresponse, profile, cloud_resource, culture, state, angular, reactref #20385