feat: add google platform alias#237
Merged
Merged
Conversation
The svg/google.svg and svg_80x80/google.svg files have shipped since 2020 but no entry in PLATFORM_TO_ICON exposes them. Add the missing alias so callers can render the icon by passing platform="google". Sentry's ContextIcon currently has to fall back to the android icon for the google device brand because of this gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
svg/google.svgandsvg_80x80/google.svgfiles have shipped since 2020 but no entry inPLATFORM_TO_ICONexposes them. As a result,<PlatformIcon platform="google" />returns the default icon instead of the Google "G".Adding the one-line alias so callers can render the existing asset.
Why this matters
Sentry's
ContextIconis being migrated from the legacysentry-logosset to platformicons. The legacy mapping had a dedicated Google logo fordevice.brand: 'google'(Pixel etc.); without this alias, the migration has to fall back to the Android icon, which is misleading — the icon represents the device brand, not the OS.Verification
svg/google.svgandsvg_80x80/google.svgexist on master.icons.generated.tsalready imports both.yarn generateis a no-op after this change (the imports were already there).yarn buildpasses.