Resolve race condition#17
Open
skatkov wants to merge 5 commits into
Open
Conversation
Guard the package-level Bubble Tea program with a mutex so task goroutines cannot race with Run while it publishes or clears the program pointer. Route program sends through a helper that snapshots the pointer under the same lock before sending.
Start task execution from the Bubble Tea model and route task lifecycle, title, progress, completion, and failure updates through messages handled by Model.Update. Tasks now mutate private snapshots and use SetTitle/SetHideView/Progress to publish safe updates, so rendering no longer reads runner/task fields concurrently with background writes.
- Simplified runRunners error flow. - Deferred taskUpdateCallbacks.Delete(...) so callback cleanup is guaranteed. - Moved ANSI escape regex compilation out of Write. - Removed low-value comments. - Straightened applyProgress’s zero-total path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing #16
Unfortunately, there are a couple of breaking changes. As an example, instead of setting .Title, now SetTitle has to be used.
It's probably ok, because this library is not stable version. But maybe it requires a CHANGELOG of some sorts?
I've been running this in my app, so far without any issues.