Feature: new filter component

[santipalenque]

https://app.clickup.com/t/86b9ruudz

Summary by CodeRabbit

• New Features

  • Modal grid filter UI with criteria/operator/value rows, AND/OR toggle, per-row add/remove, and filter-count chip; integrated into the Summit Speakers/Submitters list with server-side filtering, export, and email flows.
  • New Send Email modal for speaker/submitter lists; several reusable filter UI controls (dropdowns, toggle buttons, value inputs, round/action buttons).

• Documentation

  • Expanded GridFilter usage guide and examples; added translations for filter UI.

• Tests

  • Unit tests for filter components and behaviors.

• Chores

  • Upgraded react-redux and simplified filter parameter handling.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/components/GridFilter/__tests__/Dropdown.test.jsx (1)

94-107: ⚡ Quick win

Assert exact callback invocation count.

toHaveBeenCalled() can still pass if one selection triggers duplicate calls. Tighten this to a single expected invocation for better regression detection.

Proposed test hardening

   fireEvent.mouseDown(screen.getByRole("combobox"));
   fireEvent.click(screen.getByRole("option", { name: "Option A" }));
+  expect(onChange).toHaveBeenCalledTimes(1);
   expect(onChange).toHaveBeenCalled();

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/GridFilter/__tests__/Dropdown.test.jsx` around lines 94 - 107,
The test "calls onChange when an option is selected" uses a mock onChange but
only asserts toHaveBeenCalled(), which allows duplicate invocations; change the
assertion to expect(onChange).toHaveBeenCalledTimes(1) to ensure exactly one
invocation when fireEvent.mouseDown(...) and fireEvent.click(...) are used;
update the assertion in Dropdown.test.jsx for the onChange mock to assert a
single call.

src/components/GridFilter/GridFilter.jsx (1)

75-84: 💤 Low value

Consider using a more robust ID generation strategy.

When f.criteria is undefined (e.g., for EMPTY_FILTER), the ID becomes "undefined-0". While this works because IDs remain unique via the index, it creates non-semantic keys. Consider using a counter or generating UUIDs for cleaner filter IDs.

Alternative approach

+let filterId = 0;
+
 const handleAdd = () => {
   setFilters((prevFilters) => {
-    // replacing "new" id and adding new empty filter
-    const currentFilters = prevFilters.map((f, i) => ({
-      ...f,
-      id: `${f.criteria}-${i}`
-    }));
-    return [...currentFilters, EMPTY_FILTER];
+    return [...prevFilters, { ...EMPTY_FILTER, id: `filter-${filterId++}` }];
   });
 };

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/GridFilter/GridFilter.jsx` around lines 75 - 84, handleAdd
creates IDs using `${f.criteria}-${i}` which yields non-semantic "undefined-0"
when f.criteria is missing; change ID generation to a robust strategy by
introducing a monotonic counter state or using a UUID generator inside handleAdd
and when remapping prevFilters so every filter gets a deterministic unique id;
update the mapping in handleAdd (and creation of the appended EMPTY_FILTER) to
assign the new id (e.g., use filterIdCounter++ or uuid() to produce ids) and
ensure EMPTY_FILTER is cloned/assigned an id rather than relying on criteria for
the key.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/GridFilter/GridFilter.jsx`:
- Line 48: In GridFilter.jsx (inside the GridFilter component), correct the typo
in the inline comment: replace "rest to applied filters when closing modal
(Cancel)" with "reset to applied filters when closing modal (Cancel)" so the
comment accurately describes restoring applied filters on Cancel.

---

Nitpick comments:
In `@src/components/GridFilter/__tests__/Dropdown.test.jsx`:
- Around line 94-107: The test "calls onChange when an option is selected" uses
a mock onChange but only asserts toHaveBeenCalled(), which allows duplicate
invocations; change the assertion to expect(onChange).toHaveBeenCalledTimes(1)
to ensure exactly one invocation when fireEvent.mouseDown(...) and
fireEvent.click(...) are used; update the assertion in Dropdown.test.jsx for the
onChange mock to assert a single call.

In `@src/components/GridFilter/GridFilter.jsx`:
- Around line 75-84: handleAdd creates IDs using `${f.criteria}-${i}` which
yields non-semantic "undefined-0" when f.criteria is missing; change ID
generation to a robust strategy by introducing a monotonic counter state or
using a UUID generator inside handleAdd and when remapping prevFilters so every
filter gets a deterministic unique id; update the mapping in handleAdd (and
creation of the appended EMPTY_FILTER) to assign the new id (e.g., use
filterIdCounter++ or uuid() to produce ids) and ensure EMPTY_FILTER is
cloned/assigned an id rather than relying on criteria for the key.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2df76316-6443-42d9-8701-bae2af3803a2

📥 Commits

Reviewing files that changed from the base of the PR and between 0fb436b and 5b8293f.

📒 Files selected for processing (9)

• src/components/GridFilter/GridFilter.jsx
• src/components/GridFilter/__tests__/Dropdown.test.jsx
• src/components/GridFilter/components/Dropdown.jsx
• src/components/GridFilter/components/Filter.jsx
• src/components/GridFilter/components/FilterButton.jsx
• src/components/GridFilter/reducers/filter-reducer.js
• src/i18n/en.json
• src/pages/summit_speakers/summit-speakers-list-page/components/send-email-modal.js
• src/pages/summit_speakers/summit-speakers-list-page/index.js

🚧 Files skipped from review as they are similar to previous changes (7)

• src/components/GridFilter/components/Dropdown.jsx
• src/components/GridFilter/reducers/filter-reducer.js
• src/components/GridFilter/components/FilterButton.jsx
• src/pages/summit_speakers/summit-speakers-list-page/components/send-email-modal.js
• src/components/GridFilter/components/Filter.jsx
• src/i18n/en.json
• src/pages/summit_speakers/summit-speakers-list-page/index.js

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix typo in comment.

Change "rest to applied filters" to "reset to applied filters".

📝 Proposed fix

-      // we want to rest to applied filters when closing modal (Cancel)
+      // we want to reset to applied filters when closing modal (Cancel)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	// we want to rest to applied filters when closing modal (Cancel)
	// we want to reset to applied filters when closing modal (Cancel)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/GridFilter/GridFilter.jsx` at line 48, In GridFilter.jsx
(inside the GridFilter component), correct the typo in the inline comment:
replace "rest to applied filters when closing modal (Cancel)" with "reset to
applied filters when closing modal (Cancel)" so the comment accurately describes
restoring applied filters on Cancel.