Skip to content

IIRR-33: Filter out cloned archived puzzles#78

Merged
JuanVqz merged 3 commits into
mainfrom
IIRR-33-filter-cloned-puzzles
May 19, 2026
Merged

IIRR-33: Filter out cloned archived puzzles#78
JuanVqz merged 3 commits into
mainfrom
IIRR-33-filter-cloned-puzzles

Conversation

@arielj
Copy link
Copy Markdown
Contributor

@arielj arielj commented May 19, 2026

This PR adds a new feature to filter out already cloned puzzles from the archived table.

Currently there's no way to easily see which puzzles are already cloned, which makes it hard to know which ones should be cloned.

I'll add a few comments in the diff too

@arielj arielj requested a review from JuanVqz May 19, 2026 13:35
Comment thread app/models/puzzle.rb
Comment thread app/models/puzzle.rb Outdated
Comment thread app/models/puzzle.rb
Copy link
Copy Markdown
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that worries me a bit is the clone method, in case it might be confused with Object#clone; if that is not likely to happen, I'm fine with this.

@arielj thoughts?

Comment thread app/models/puzzle.rb
JuanVqz added a commit that referenced this pull request May 19, 2026
- Remove random answers for approved puzzles. Real users only answer
  puzzles after they've been sent (archived state).
- Add two cloned puzzles so the 'hide cloned puzzles' filter from #78
  has data to filter.
@JuanVqz
Copy link
Copy Markdown
Member

JuanVqz commented May 19, 2026

QA went good! thanks

@JuanVqz JuanVqz merged commit 674161a into main May 19, 2026
7 of 8 checks passed
JuanVqz added a commit that referenced this pull request May 19, 2026
- Remove random answers for approved puzzles. Real users only answer
  puzzles after they've been sent (archived state).
- Add two cloned puzzles so the 'hide cloned puzzles' filter from #78
  has data to filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants