Skip to content

Add support for pre-releases#107

Merged
dmorgan-fa merged 1 commit into
masterfrom
dcm/support-pre-release-via-workflow
May 19, 2026
Merged

Add support for pre-releases#107
dmorgan-fa merged 1 commit into
masterfrom
dcm/support-pre-release-via-workflow

Conversation

@dmorgan-fa
Copy link
Copy Markdown
Contributor

@dmorgan-fa dmorgan-fa commented May 19, 2026

Nikolas is interested in supporting pre-releases:

The intended workflow here is:

  • Create a branch with changes
  • Bump version.rb to a pre-release version
  • Push to GitHub

The workflow will:

  • runs the tests
  • checks if version is a pre-release
  • triggers a pre-release (only supported on non-master branches)
  • trigger a release (only supported on master)

@dmorgan-fa dmorgan-fa requested a review from a team as a code owner May 19, 2026 14:51
Copy link
Copy Markdown
Member

@dgholz dgholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow looks extremely similar to the freeagent-gem workflow. Could we combine them?

I think the logic to do that is to remove the branch filter, and check that either the context is the default branch (a release) or that the version looks like a prerelease

Nikolas is interested in supporting pre-releases:
- Slack Thread
  https://freeagent.slack.com/archives/C0YCN9R5Y/p1779199637271789

The intended workflow here is:
- Create a branch with changes
- Bump `version.rb` to a pre-release version
- Push to GitHub

The workflow will:
- runs the tests
- checks if version is a pre-release
- triggers a pre-release (only supported on non-master branches)
- trigger a release (only supported on master)
@dmorgan-fa dmorgan-fa force-pushed the dcm/support-pre-release-via-workflow branch from 3286eff to 9565969 Compare May 19, 2026 15:13
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 19, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dmorgan-fa
Copy link
Copy Markdown
Contributor Author

@dgholz, yeah that's fair.
@NikolasPilavakis and I are pairing on this just now, and initially I went down the route of a workflow_dispatch (hence the duplicated file).

Updated now to handle it within the same workflow.

@dmorgan-fa dmorgan-fa requested a review from dgholz May 19, 2026 15:16
@dmorgan-fa dmorgan-fa merged commit 44010b1 into master May 19, 2026
4 checks passed
@dmorgan-fa dmorgan-fa deleted the dcm/support-pre-release-via-workflow branch May 19, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants