Warn and fall back when cookieOptions.domain is a Public Suffix List entry#70
Warn and fall back when cookieOptions.domain is a Public Suffix List entry#70pepeladeira wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR guards cookie domain configuration against browser Public Suffix List (PSL) limitations by introducing a ChangesPublic Suffix List Cookie Domain Guard
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/script/src/base.js`:
- Around line 44-47: The PSL membership check is case-sensitive so domains like
`.Vercel.App` bypass the warning; normalize the configured domain before lookup
by lowercasing (and trimming the leading dot as already done) so the
`KNOWN_PSL_DOMAINS.includes(bare)` check is consistent—update how `bare` is
derived from `parsedOpts.domain` (used in the `if (parsedOpts.domain)` branch)
to produce a normalized lowercase domain prior to calling
`KNOWN_PSL_DOMAINS.includes`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8b3c58ce-c9a8-47af-9a1f-92d0891d96b8
📒 Files selected for processing (3)
packages/script/src/base.jspackages/web/README.mdpackages/web/src/types.ts
Summary by CodeRabbit
Bug Fixes
Documentation