test: use t.Fatal/t.Helper in helpers and implement TestNewFile#40
Open
leno23 wants to merge 1 commit into
Open
test: use t.Fatal/t.Helper in helpers and implement TestNewFile#40leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Replace log.Fatal in test setup helpers with testing.TB.Fatal so a single setup failure does not abort the entire test binary. Add t.Helper() to assertion helpers for accurate failure line reporting. Implement TestNewFile for absolute and relative paths. Fixes dolph#33 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log.Fatalin test setup helpers withtesting.TB.Fatalso one setup failure does not exit the whole test binaryt.Helper()to assertion helpers for accurate failure attributionTestNewFilecovering absolute and relative pathsFixes #33
Made with Cursor