Use playwright install-deps to avoid fragile output parsing#198
Closed
djbender wants to merge 1 commit into
Closed
Use playwright install-deps to avoid fragile output parsing#198djbender wants to merge 1 commit into
djbender wants to merge 1 commit into
Conversation
The previous step parsed `npx playwright install --dry-run --with-deps` output to extract a sudo command. Playwright 1.60.0 changed that output so the extracted string contains an unescaped `(` and breaks `sh`, blocking the playwright bump in #195. Use the documented `playwright install-deps` subcommand instead -- it installs only the system packages (browsers come from the cache step below).
Owner
Author
|
Superseded — the same workflow fix has been pushed directly onto #195's branch so the playwright bump can land in one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npx playwright install --dry-runoutput parsing with the documentedplaywright install-depssubcommand(, causingsh: 1: Syntax error: "(" unexpectedin the CI Test jobRoot cause
The previous step did:
This scrapes a non-contract output line. Playwright 1.60.0 changed that line so the extracted string includes characters that don't parse in plain
sh.playwright install-depsis the documented CLI for "install system packages but not browsers" — exactly what this step needs, since the next step uses an actions/cache for the browser binaries.Test plan