[deckhouse-cli] Adding new commands and fix bugs in the debug archive#354
Open
VaLosev wants to merge 3 commits into
Open
[deckhouse-cli] Adding new commands and fix bugs in the debug archive#354VaLosev wants to merge 3 commits into
VaLosev wants to merge 3 commits into
Conversation
Signed-off-by: Losev Valery <valery.losev@flant.com>
Signed-off-by: Losev Valery <valery.losev@flant.com>
Signed-off-by: Losev Valery <valery.losev@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collect-debug-info command execution logic has been improved:
RequiredModuleandExpandPerModulehave been added to theCommandstructure to more accurately verify that a module is enabled and data should be collected from it. To support this new functionality, the following functions have been modified:fetchActiveModules(gets a list of modules in thetatus.phase == "Ready"state) andfilterAndExpandCommands(accepts a list of enabled modules from fetchActiveModules and filters the data to be collected into the archive by RequiredModule and ExpandPerModule). The final logic is as follows:To prevent excessive API load in busy clusters, two flags have been added for more granular control over query execution:
--command-timeoutflag is the maximum execution time for a single collection command. If the command hangs or the API is unresponsive, it will be interrupted after 2m by default.--request-intervalflag allows you to configure pauses between command starts for the kubernetes API. By default, there is no delay.An example of command execution has been added to Examples:
Added data assemblies:
--api-group=storage.deckhouse.ioobjects and displays those that havemetadata.deletionTimestampset (meaning they have already been sent a delete message), but they are stuck in “terminating”)P.S. Istio data collection now only occurs when the module is enabled.