feat: add spacebar hold for 2x speed in player with proper listener c…#1923
Open
i-amansharma07 wants to merge 1 commit into
Open
feat: add spacebar hold for 2x speed in player with proper listener c…#1923i-amansharma07 wants to merge 1 commit into
i-amansharma07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was missing
The player had no way to temporarily boost speed by holding a key. This PR adds the spacebar hold gesture which is a common pattern in video players (e.g. YouTube).
What was added
Cleanup Logic
Both listeners are correctly registered and removed:
keydownis registered with{ capture: true }so it fires before Video.jsinternal handlers can intercept it. The removal must mirror the same flag —
without it, the browser treats capture and non-capture registrations as distinct
listeners and the removal becomes a no-op, leaking the listener on every unmount.
keyupremoval was simply absent, causing a new duplicate listener to stack upon every re-render triggered by
playerstate changes.Checklist before requesting a review