Merging minor improvements and tuning of the code and plotting parameters#76
Open
oglez wants to merge 2 commits into
Open
Merging minor improvements and tuning of the code and plotting parameters#76oglez wants to merge 2 commits into
oglez wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two commits contain several modifications to the code. The second one is to prevent some complaint in the CI/CD checks as some versions of the actions were becoming obsolete. It seems to be transparent.
The other introduces certain changes in the code that should be mostly transparent or improvement. A list of the main changes are here:
Some of the methods which allow an efficient use of the package are modified/improved. These are mostly the codes that I do not think anyone but me (Oscar) actually uses. This includes some changes on script files (only used by maintainers) and in the C++ version.
Changes of some more used methods, motivated to improve usability (these should be transparent for the previously supported uses) or to fine-tune some axis-related values (these are not transparent, but changes are minor. They are mostly motivated as some exponents and similar where overlaping... for the cases the code before was fine the new is fine and the outcome the same for any practical comparison)
Changing the default colours for the Brazilian plot to use new standards proposed by Andrzej on 2026_02_12 (to improve the printing version, was it?). Old version of the colours are kept with changed names in case they are needed, although the differences are practically irrelevant.