Walker fixes

[TheHaliax]

No description provided.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 918297b8-17c3-453d-8c30-dec35add505e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

This PR refactors Rs2Walker's transport and door interaction semantics by introducing catalog-backed transport segment detection. The changes prevent door-probing logic from interfering with explicit transports by identifying catalog-registered transport edges and excluding associated objects from door resolution flows. Canvas walking gains null-point handling with minimap fallback, and transport completion switches to a tiered fallback chain. Rs2MiniMap is simplified by removing a debug log from its null-return path.

Possibly related PRs

• chsami/Microbot#1506: Modifies Rs2Walker's transport-walking and transport-selection logic including POH/canonical transport handling, directly related to this PR's catalog-backed transport semantics refactoring.
• chsami/Microbot#1672: Updates Rs2Walker's transport handling with Magic Mushtree-specific logic, whereas this PR refactors transport detection to catalog-backed segments and adjusts obstacle interaction accordingly.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 37.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Walker fixes' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the specific changes made.	Consider using a more specific title that describes the primary fix, such as 'Improve walker transport edge detection with catalog-backed logic' or 'Fix walker navigation by replacing hasExplicitTransportStep with catalog detection'.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess relevance to the changeset.	Add a description explaining the walker fixes, including the motivation for switching to catalog-backed transport detection and the impact on navigation behavior.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java`:
- Around line 4146-4173: The plane equality checks are preventing cross-plane
catalog transports from being recognized; update isCatalogBackedTransportSegment
and matchesDirectedTransportCatalogEdge to not bail out when origin.getPlane()
!= dest.getPlane() so ladder/stair/trapdoor entries in the transport catalog are
matched across planes. Keep the null checks for origin/dest, but remove or relax
the plane comparison in both methods (isCatalogBackedTransportSegment and
matchesDirectedTransportCatalogEdge) so the transports lookup via
ShortestPathPlugin.getTransports().get(origin) and the subsequent anyMatch(t ->
Objects.equals(t.getDestination(), dest)) can find cross-plane entries.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 71742726-7964-4324-8dc6-db9014e08725

📥 Commits

Reviewing files that changed from the base of the PR and between 9fda631 and 45dde1b.

📒 Files selected for processing (2)

• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2MiniMap.java
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java

💤 Files with no reviewable changes (1)

• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2MiniMap.java