Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Draft
Member
You have to configure the github token to run them. I run them OK in the past locally but lately I just relied on the CI - cause I didn't want to create a fresh token ;p |
Andarist
reviewed
May 18, 2026
| export const ROOT_TEST_BRANCH_PREFIX = global.ROOT_TEST_BRANCH_PREFIX; | ||
| export const ROOT_TEMP_DIRECTORY = global.ROOT_TEMP_DIRECTORY; | ||
| export const ROOT_TEST_BRANCH_PREFIX = process.env | ||
| .ROOT_TEST_BRANCH_PREFIX as string; |
Member
There was a problem hiding this comment.
nit: i'd prefer the more narrowly-scoped cast in such case:
Suggested change
| .ROOT_TEST_BRANCH_PREFIX as string; | |
| .ROOT_TEST_BRANCH_PREFIX!; |
Andarist
reviewed
May 18, 2026
| .ROOT_TEST_BRANCH_PREFIX as string; | ||
| export const ROOT_TEMP_DIRECTORY = process.env.ROOT_TEMP_DIRECTORY as string; | ||
|
|
||
| configDotenv(); |
Member
There was a problem hiding this comment.
It feels weird/wrong that this comes after unpacking the variables from process.env
Andarist
reviewed
May 18, 2026
| "format:fix": "prettier --write \"**/*.{ts,tsx,md}\"", | ||
| "lint": "eslint . --max-warnings 0", | ||
| "test:integration": "jest --config jest.integration.config.cjs" | ||
| "test:integration": "vitest -c vitest.integration.config.ts" |
Member
There was a problem hiding this comment.
we even have any other tests? it feels like this is just the default test suite here and we perhaps don't need to nest/namespace it under integration name
Andarist
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No idea if this works. It's quite hard to run the tests.