Skip to content

Fix shared deployment smoke assistant ids #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 1 commit into from
May 19, 2026
+4 −4
Merged

Fix shared deployment smoke assistant ids #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/cockpit/src/lib/verify-shared-deployment.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {

describe('verify-shared-deployment', () => {
it('allows the two-pass planning graph more time than single-response smoke assistants', () => {
expect(getSmokeAssistantStreamTimeoutMs('planning')).toBe(90000);
expect(getSmokeAssistantStreamTimeoutMs('da-planning')).toBe(90000);
expect(getSmokeAssistantStreamTimeoutMs('streaming')).toBe(
DEFAULT_SMOKE_ASSISTANT_STREAM_TIMEOUT_MS,
);
Expand Down
6 changes: 3 additions & 3 deletions scripts/verify-shared-deployment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ const REQUIRED_URL_KEYS = [
const SMOKE_ASSISTANT_IDS = [
'streaming',
'deployment-runtime',
'planning',
'filesystem',
'da-planning',
'da-filesystem',
'c-generative-ui',
'c-a2ui',
'chat',
Expand All @@ -37,7 +37,7 @@ export const DEFAULT_SMOKE_ASSISTANT_STREAM_TIMEOUT_MS = 30000;
const SMOKE_ASSISTANT_STREAM_TIMEOUT_MS: Partial<Record<SmokeAssistantId, number>> = {
// The planning graph intentionally performs two model calls: one to create
// structured plan state, then one to execute the plan and answer.
planning: 90000,
'da-planning': 90000,
// UI graph assistants can include extra model/tool work before the first AI
// stream event, and CI has observed them occasionally crossing 30s.
'c-generative-ui': 90000,
Expand Down