Skip to content

Sidebar mode: enable pushContent so the panel pushes content left#456

Merged
blove merged 1 commit into
mainfrom
claude/sidebar-push-content
May 19, 2026
Merged

Sidebar mode: enable pushContent so the panel pushes content left#456
blove merged 1 commit into
mainfrom
claude/sidebar-push-content

Conversation

@blove
Copy link
Copy Markdown
Contributor

@blove blove commented May 19, 2026

Summary

  • chat-sidebar already supports `[pushContent]`: when true and `open`, the lib applies `margin-right: 28rem` to its default content slot. Setting `[pushContent]="true"` in sidebar-mode now pushes the page background left of the panel rather than overlaying.
  • Restructured sidebar-mode to project the `.sidebar-mode__background` div INTO chat-sidebar's default `` slot (was a sibling). Now the push margin actually applies to it.
  • Background height switched from `height: 100%` to `min-height: calc(100dvh - var(--demo-toolbar-height, 51px))` so the area below the toolbar is filled exactly.
  • Override `min-height: 0 !important` on `.chat-sidebar__content` to defeat the lib's `min-height: 100vh` (would push content 51px past viewport in our flex column under the top toolbar).

Demo-only change. No lib touched.

Test plan

  • Local chrome-mcp: panel open → `data-push: "true"`, `data-open: "true"`, `.chat-sidebar__content` margin-right 448px (= 28rem), background bgRight 1352 ≈ panelLeft 1351 (content cleanly bounded), pageOverflow 0
  • Canonical demo redeploys on demo.threadplane.ai

🤖 Generated with Claude Code

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadplane Ready Ready Preview, Comment May 19, 2026 4:11am

Request Review

@blove blove merged commit 22f8597 into main May 19, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant