fix(popup): map edited timestamp to threaded-annotations updatedAt#757
Open
jackiejou wants to merge 1 commit into
Open
fix(popup): map edited timestamp to threaded-annotations updatedAt#757jackiejou wants to merge 1 commit into
jackiejou wants to merge 1 commit into
Conversation
Populate updatedAt on the root description message so PopupV2 surfaces the edited indicator after the user edits an annotation. The thread component reads updatedAt to decide whether to render the indicator and expects it undefined for unedited messages. Compare parsed instants instead of raw ISO strings so equivalent formats (Z vs +00:00, fractional precision) are treated as unedited. Unparseable modified_at falls back to undefined; the consumer hides the indicator rather than crashing the popup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The threaded-annotations v2 thread component shows an edited indicator on a message when its
updatedAtis set to a timestamp newer thancreatedAt. The box-annotations adapter was not populatingupdatedAt, so even after the user edited an annotation in PopupV2, the thread never rendered the indicator.This change maps
Annotation.modified_atto the root messageupdatedAtwhen it differs fromcreated_at. Replies are unaffected because the API model has nomodified_atonReplyand the adapter forcescanEdit: falsefor replies.Implementation notes
getTime()) rather than raw ISO strings, so equivalent normalizations (Zvs+00:00, fractional precision) are treated as unedited.undefinedfor unparseablemodified_at. The consumer simply hides the indicator in that case rather than crashing the popup; the field is optional in the public type.Test plan