feat(tracing): add snapshot spans and propagator setup#309
Draft
worstell wants to merge 1 commit into
Draft
Conversation
Adds two manual spans on the snapshot create/restore paths and registers a W3C TraceContext + Baggage propagator so trace IDs flow across HTTP boundaries (otelhttp uses the global propagator; without this, every service starts a new trace). New spans: - cachew.snapshot.create - cachew.snapshot.restore Amp-Thread-ID: https://ampcode.com/threads/T-019e28cc-12d9-766e-8a0d-7d42c46c824d Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two manual spans on the snapshot create/restore paths and registers a W3C TraceContext + Baggage propagator inside
tracing.Newso trace IDs flow across HTTP boundaries (otelhttp uses the global propagator, which was previously unset, so every service started a new trace).New spans:
cachew.snapshot.create(ininternal/snapshot/snapshot.goCreatePaths) — covers archive + zstd + uploadcachew.snapshot.restore(ininternal/snapshot/snapshot.goRestore) — covers download + zstd + extractEach span carries the cache key, archive name (create only), thread count, and exclude/include path counts as attributes.