Tui Clean Up#314
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
@copilot review but do not make fixes |
arul28
force-pushed
the
ade/tui-clean-up-68fafd96
branch
from
e5c9332 to
3172a3f
Compare
Reviewed commit 3172a3f without making fixes. I don’t see any blocking issues in the lane deletion recovery, targeted same-repo PR backfill, or lane PR badge matching changes. I attempted targeted validation, but |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
@copilot review but do not make fixes |
Summary
Describe the change.
What Changed
Key files and behaviors.
Validation
How you tested.
Risks
Anything to watch.
Greptile Summary
This PR addresses two previously flagged issues — per-branch fault isolation in
fetchMissingSameRepoLanePullsand the terminal-GitHub-PR preference inshouldPreferGithubPrTag— and adds supporting infrastructure: fork-PR discrimination in branch matching, residual-file cleanup aftergit worktree remove, and a forced GitHub snapshot refresh triggered by lane branch-signature changes.laneService.ts: ExtractsremoveResidualDirectoryso both the success and failure paths aftergit worktree removeshare the samefs.promises.rm+git worktree prunecleanup; adds a post-success existence check to catch git reporting exit 0 while leaving files behind.prService.ts: AddsfetchMissingSameRepoLanePulls, capped at 12 branches, with per-branch try/catch so a single flaky API call doesn't abort the remaining lookups; populatesheadRepoOwner/headRepoNameon mappedGitHubPrListItemrows.lanePageModel.ts: Adds a same-repo owner/name guard togithubPrMatchesCurrentBranch(blocking fork PRs with matching branch names) and introducesshouldPreferGithubPrTagwhich restricts the branch-reuse preference to non-terminal GitHub PRs.Confidence Score: 5/5
Safe to merge — all changed paths are well-covered by new tests and directly address previously identified gaps.
The three substantive logic changes (worktree residual cleanup, per-branch fault isolation, and the GitHub-vs-ADE PR tag preference) each have dedicated unit tests that exercise the exact scenarios they fix. The type additions are backward-compatible optional fields. No regressions are apparent in the shared selector or snapshot-fetch paths.
No files require special attention.
Important Files Changed
removeResidualDirectoryhelper so both the success-path and failure-path worktree cleanup share the samefs.promises.rm+git worktree prunelogic; now also checks for residual files after a zero-exitgit worktree remove.fetchMissingSameRepoLanePulls(capped at 12 branches, per-branch fault-isolated with try/catch+continue) and helper extractors for head-repo fields; also populatesheadRepoOwner/headRepoNameon mappedGitHubPrListItemrows.githubPrMatchesCurrentBranchand introducesshouldPreferGithubPrTagwhich correctly restricts branch-reuse preference to non-terminal GitHub PRs.lanePrBranchSignaturememo to trigger a forced GitHub snapshot refresh whenever the set of lane branches/types changes.headRepoOwnerandheadRepoNamefields toGitHubPrListItemto support fork-PR discrimination in the renderer.git worktree removeare cleaned up and thatgit worktree pruneis called before the lane row is deleted.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[getGithubSnapshot] --> B[fetchAllPages repo PRs] B --> C[fetchMissingSameRepoLanePulls] C --> D{Active lane branches\nwithout same-repo PR?} D -- No --> G[backfillLanePrRowsFromGithubPulls] D -- Yes, up to 12 --> E[Per-branch targeted fetch\nhead=owner:branch] E --> F{API error?} F -- Yes --> E2[log warn, continue next branch] F -- No --> E3[Deduplicate by PR number\nadd to rawPulls] E2 --> G E3 --> G G --> H[selectLaneTabPrTag in renderer] H --> I{mappedPr exists?} I -- Yes --> J[selectTerminalGithubUpdateForPr] J -- terminal match --> K[return GitHub terminal tag] J -- no match --> L{shouldPreferGithubPrTag?} L -- same PR state differs OR ADE terminal + GitHub live --> M[return githubPr tag] L -- No --> N[return ADE mapped PR tag] I -- No --> O{githubPr branch match?} O -- Yes, same-repo owner+name check passes --> P[return GitHub PR tag] O -- No / fork PR blocked --> Q[return null]Reviews (2): Last reviewed commit: "ship: iteration 1 - address Greptile PR ..." | Re-trigger Greptile