fix(frontend): keep About-page sign-in panel from overlapping content#5132
Merged
Merged
Conversation
On the logged-out About page, the sign-in panel was rendered inside the `.content` column with `position: absolute; top: 130px; right: 0;`. Because the absolutely-positioned panel was removed from layout flow, the surrounding `<p>` description and `<h2>` headings had no right-side reserved space and flowed underneath the panel, leaving the right edge of the text visually overlapped. Restructure the page so the title + description still span the full content width, and add a sub-row that places the feature-list column side-by-side with the sign-in column: - Drop the unused outer `nz-row` on `.about-page-container` and the unused `nz-col` on `.content` (they only ever held one child, so the flex grid was inert). - Introduce a `.features-row` inside `.content` that pairs the feature-list (`nzFlex="auto"`) with a 350px sign-in column. The workflow-GUI screenshot and Learn More section stay below at full width. - Replace `position: absolute; top: 130px; right: 0; max-width: 350px; width: 100%;` on `.login-container` with a normal-flow `margin-top: 10px;` so its top aligns with the feature-list `<h2>`. - Loosen `.content > h2` to `.content h2` so the (now-nested) feature heading still gets the 10px top margin. On viewports narrow enough that 350px + auto cannot fit side-by-side, `nz-row`'s default `flex-wrap: wrap` lets the sign-in column drop below the feature list rather than overlap it. Closes apache#5126. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
If the video is for the site after the change, please also add one for the site before the change. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5132 +/- ##
=========================================
Coverage 43.18% 43.19%
Complexity 2210 2210
=========================================
Files 1045 1045
Lines 40262 40265 +3
Branches 4251 4251
=========================================
+ Hits 17389 17392 +3
Misses 21803 21803
Partials 1070 1070
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
it's in the linked issue, I can also include it in this pr |
aglinxinyuan
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
On the logged-out About page, the sign-in panel was rendered inside the
.contentcolumn withposition: absolute; top: 130px; right: 0;. Because the absolutely-positioned panel was removed from layout flow, the surrounding<p>description and<h2>headings had no right-side reserved space and flowed underneath the panel, leaving the right edge of the text visually overlapped (see #5126 screenshot).This PR restructures the page so the title + description still span the full content width, and adds a sub-row that places the feature-list column side-by-side with the sign-in column:
nz-rowon.about-page-containerand the unusednz-colon.content(they only ever held one child, so the flex grid was inert)..features-rowinside.contentthat pairs the feature-list (nzFlex="auto") with a 350px sign-in column. The workflow-GUI screenshot and Learn More section stay below at full width.position: absolute; top: 130px; right: 0; max-width: 350px; width: 100%;on.login-containerwith a normal-flowmargin-top: 10px;so its top aligns with the feature-list<h2>..content > h2to.content h2so the (now-nested) feature heading still gets the 10px top margin.On viewports narrow enough that 350px + auto cannot fit side-by-side,
nz-row's defaultflex-wrap: wraplets the sign-in column drop below the feature list rather than overlap it.before change
demo (after change)
record1.mov
Any related issues, documentation, discussions?
Closes #5126.
How was this PR tested?
CSS / template-only layout change. No automated test added — a unit test would only assert that
*ngIftoggles a DOM node, which is a tautology of the template. Verified locally on the logged-out About page: title + description span the full width, feature-list and sign-in panel sit side by side, content no longer slides under the panel, and dragging the window narrow makes the panel wrap below instead of overflowing.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-7)