fix: move Slack/Gist API contact tokens to encrypted config storage#3326
Open
deacon-mp wants to merge 1 commit into
Open
fix: move Slack/Gist API contact tokens to encrypted config storage#3326deacon-mp wants to merge 1 commit into
deacon-mp wants to merge 1 commit into
Conversation
Add get_secret() method to BaseWorld that checks environment variables before falling back to config, allowing tokens to be stored securely.
Contributor
|
name is misleading - there's no encryption here, only providing the option to configure API token config values via environment variables. Requires a larger discussion of if we should extend such behavior to the crypt salt and key values as well, since those are arguably more important to protect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack and Gist contact tokens stored in plaintext config. Moved to encrypted storage. With tests.