Skip to content

Fix BEGIN READ WRITE regression for Redshift syntax#844

Open
divaltor wants to merge 1 commit into
andialbrecht:masterfrom
divaltor:redshift-syntax-843
Open

Fix BEGIN READ WRITE regression for Redshift syntax#844
divaltor wants to merge 1 commit into
andialbrecht:masterfrom
divaltor:redshift-syntax-843

Conversation

@divaltor
Copy link
Copy Markdown

Redshift allows BEGIN with transaction mode modifiers such as READ WRITE or ISOLATION LEVEL. Treat those tokens like transaction starters so split() does not mistake BEGIN for a procedural block.

Thanks for contributing!

Before submitting your pull request please have a look at the
following checklist:

  • ran the tests (pytest)
  • all style issues addressed (flake8)
  • your changes are covered by tests
  • your changes are documented, if needed

Described in #843


Note: This repository has automated AI code reviews enabled to help catch
potential issues early and provide suggestions. This is an experimental
feature to support maintainers and contributors – your feedback is welcome!

Redshift allows BEGIN with transaction mode modifiers such as READ WRITE or ISOLATION LEVEL. Treat those tokens like transaction starters so split() does not mistake BEGIN for a procedural block.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.52%. Comparing base (7334ac9) to head (aadda6b).
⚠️ Report is 100 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
+ Coverage   97.04%   97.52%   +0.47%     
==========================================
  Files          20       31      +11     
  Lines        1558     3590    +2032     
  Branches        0      314     +314     
==========================================
+ Hits         1512     3501    +1989     
- Misses         46       54       +8     
- Partials        0       35      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant