feat: add explicit docker cleanup script retention#798
Merged
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a cleanup.sh script designed to optimize Docker images by purging unnecessary packages and removing build-time scripts. The review feedback highlights that the apt-get purge command should be wrapped in a conditional block to respect the --keep-scripts flag, preventing the removal of tools like curl and wget when they are still needed for subsequent build steps. Additionally, the feedback suggests including git in the purge list and refactoring the brittle directory name check to ensure the script directory is reliably removed even if renamed.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanup.shto accept--keep-scriptsbash ./bash/cleanup.shas the final cleanup path that removes the copied./bashhelper directoryWhy
configure-yarn.shWB_KEEP_DOCKER_SCRIPTSdist/bashoutputTesting
bash -n packages/wb/docker/bash/cleanup.shrg "install-asdf\\.sh|prepare-asdf.*\\.sh|prepare-asdf\\.sh" packages/wb packages/wbfy -g '!node_modules' -g '!dist'yarn verify