Skip to content

Improved class aggregation for upstream/downstream connectivity queries#40

Open
Clare72 wants to merge 3 commits into
mainfrom
connectivity_queries
Open

Improved class aggregation for upstream/downstream connectivity queries#40
Clare72 wants to merge 3 commits into
mainfrom
connectivity_queries

Conversation

@Clare72
Copy link
Copy Markdown
Contributor

@Clare72 Clare72 commented May 11, 2026

No description provided.

@Clare72 Clare72 requested a review from Robbie1977 May 12, 2026 10:25
@Robbie1977
Copy link
Copy Markdown
Contributor

@Clare72
Copy link
Copy Markdown
Contributor Author

Clare72 commented May 19, 2026

Tests that exist but aren't wired into CI

Five connectivity test files in src/test/:

File What it covers In performance job? In python-test job?
test_neuron_neuron_connectivity.py per-neuron partly (via test_query_performance's test_07) no
test_neuron_region_connectivity.py per-neuron partly (via test_07) no
test_upstream_class_connectivity.py class-level no no
test_downstream_class_connectivity.py class-level no no
test_vfb_connectivity.py query_connectivity (cross-dataset) no no

The other CI workflow (python-test.yml) only runs term_info_queries_test.py.

So the three connectivity test files for the class-level and cross-dataset
queries are effectively orphaned — they'll only get exercised if someone runs
them locally.

Shall I add them all @Robbie1977 ?

@Robbie1977
Copy link
Copy Markdown
Contributor

@Clare72 yes please

@Robbie1977
Copy link
Copy Markdown
Contributor

@Clare72 Can you get Claude to check why the tests failed silently and resolve the errors shown in https://github.com/VirtualFlyBrain/VFBquery/actions/runs/26111178920/attempts/1#summary-76788537996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants