feat: data quality - filter null geometry, diagnostic endpoint (Meta #5, #6)#94
Open
madhavcodez wants to merge 3 commits into
Open
feat: data quality - filter null geometry, diagnostic endpoint (Meta #5, #6)#94madhavcodez wants to merge 3 commits into
madhavcodez wants to merge 3 commits into
Conversation
… dashed imageless polygons - /locations: filter out NULL geometry locations (root cause of Meta #5 sidebar-map mismatch) - /disasters/{id}/summary: exclude NULL geometry from aggregate counts and classification breakdown - New /data-quality/report endpoint with storage analysis for bucket reduction (Meta #6) - Frontend: hasOverlay field on MapPolygon, dashed stroke for imageless polygons (FE #70) - Frontend: sidebar tile count excludes geometry-less locations Addresses Meta #5, FE #70, Meta #6
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Update system prompt to explain the xBD dataset covers only Pender County (NC), Duplin County (NC), and Horry County (SC). Queries for areas outside these counties now return a clear explanation instead of a confusing partial response. Empty get_damage_by_area results also include the coverage note.
Remove MOCK_CHATS dict and /chat/mock-conversations endpoints superseded by real chat router. Fix duplicate flyTo action when Gemini calls both get_damage_hotspots and navigate_map in the same round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
l.geom IS NOT NULLin/locationsand/disasters/{id}/summary- locations without geometry were counted in sidebar but never rendered on map, causing mismatchhasOverlayboolean on MapPolygon, dashed stroke for polygons without satellite imagery overlayGET /data-quality/report?disaster_id=...diagnostic endpoint - reports location/image-pair data quality metricsChanges
Backend (3 files)
app/main.py: Addedl.geom IS NOT NULLto WHERE clauses; registered data_quality routerapp/routers/data_quality.py(NEW): Diagnostic endpoint with COUNT+FILTER SQLapp/services/gemini.py: Updated system prompt with Florence dataset coverage boundaries; improved empty-result responsesFrontend (3 files)
types.ts: AddedhasOverlay?: booleanto MapPolygon interfaceDashboard.tsx: ThreadhasOverlaythrough polygon parser, filter sidebar tile countsMapView.tsx: Dashed stroke for polygons wherehasOverlay === falseCloses UTDisaster/meta#5, UTDisaster/frontend#70, UTDisaster/meta#6
Test plan
GET /data-quality/report?disaster_id=hurricane-florencereturns valid JSONGET /data-quality/reportwithout disaster_id returns 422