Feat/boards#71
Open
maksberegovoi wants to merge 14 commits into
Open
Conversation
… board management
…ipts for k6 testing
soorq
requested changes
May 11, 2026
maksberegovoi
force-pushed
the
feat/boards
branch
from
b4bab80 to
d46571e
Compare
soorq
requested changes
May 18, 2026
| ApiResponse({ | ||
| status: 201, | ||
| description: 'Представление создано', | ||
| type: CreateBoardViewResponse.Output, |
Collaborator
There was a problem hiding this comment.
Тут я тебе говорил, нету смысла лепить createResponse, зачем, мы в дальнейшем с фронтом уже обсудим, чтоб он хотел видеть, и уже доделаем response контракты, а пока описывать и отдавать фулл схемы после создания - зачем.. на 1ом контракте с действием идем ведь
| code: 'DELETE_FAILED', | ||
| message: 'Не удалось удалить колонку доски', | ||
| }, | ||
| HttpStatus.SERVICE_UNAVAILABLE, |
Collaborator
There was a problem hiding this comment.
Спорно, но окей, пока пусть будет так
| code: 'DELETE_FAILED', | ||
| message: 'Не удалось удалить доску', | ||
| }, | ||
| HttpStatus.SERVICE_UNAVAILABLE, |
Collaborator
There was a problem hiding this comment.
unavailable отдаст прокси, если чет навернется, либо хелз, но методы не должны такого уметь делать)
| projectId: string, | ||
| userId: string, | ||
| dto: CreateBoardDto, | ||
| ): Promise<CreateBoardResponse> { |
Collaborator
There was a problem hiding this comment.
Все типы переделай на zodContract, чтоб точно держать в деле и типы, и ответы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.