chore: sync version markers to 1.1.0 (race-condition catchup)#12
Merged
Conversation
release-please was supposed to bump CMakeLists.txt + version.hpp in PR #11 along with .release-please-manifest.json and CHANGELOG.md, but PR #10 (which added the extra-files wiring) and PR #11 (the release PR) were merged within ~2 minutes — too fast for release-please to re-run between them. The result: PR #11 merged with only the manifest + CHANGELOG bumped, leaving the in-source version constants stuck at 1.0.3 while the released tag is v1.1.0. This commit catches them up by hand. From the next release onward, release-please will rewrite all four files in lock-step automatically because the extra-files config from PR #10 is now in main. Files synced: CMakeLists.txt VERSION 1.0.3 → 1.1.0 framework/_meta/include/phyriad/version.hpp MAJOR 1 / MINOR 0 → 1 / PATCH 3 → 0 / STRING "1.0.3" → "1.1.0" apps/ayama/CMakeLists.txt and apps/ayama/core/include/ayama/version.hpp stay at 0.1.3 — Ayama did not bump in this release cycle (zero ayama-scoped commits since ayama-v0.1.3). Operational lesson: when merging a release-please PR, wait ~60 s between merging the wiring-PR and the release-PR so release-please can re-run and update the release-PR with the additional bumps. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.1.0was just published but the in-source version constants stayed at1.0.3due to a release-please race condition: PR #10 (extra-files wiring) and PR #11 (release PR) were merged ~2 min apart, faster than release-please could re-run to update PR #11 with the additional file bumps.Result of the race
.release-please-manifest.json1.1.01.1.0✓CHANGELOG.mdCMakeLists.txt(VERSION ...)1.1.01.0.3✗framework/_meta/include/phyriad/version.hpp1.1.01.0.3✗So
phyriad-ayama-windows-1.1.0.zip(already published) contains binaries that reportPHYRIAD_VERSION_STRING = "1.0.3"at runtime. The fix can't unship that asset, but it sets the right baseline forv1.1.1/v1.2.0and any future build off main.What this PR does
Manually applies the bumps release-please would have done:
CMakeLists.txt:VERSION 1.0.3→1.1.0version.hpp:_MINOR 0→1,_PATCH 3→0,_STRING "1.0.3"→"1.1.0"Ayama files stay at 0.1.3 — no Ayama-scoped commits in this release cycle.
How to prevent this next time
After merging a release-please-related PR, wait ~60 s before merging the release PR so release-please can re-run on the latest main and update the release PR with all the file bumps. Or, simpler, inspect the release PR's diff before merging — if it only shows
manifest + CHANGELOG, wait for the re-run.Test plan
🤖 Generated with Claude Code