Fix dialogs that need to be modal#62
Merged
Merged
Conversation
There are two dialogs which are expected to block and not return immediately. They are broken since 45bf80f when the code base was updated to JUCE 6.1.0. Refactoring those to be asynchronous isn't trivial. To keep them working for now `JUCE_MODAL_LOOPS_PERMITTED` is being set to `1`, like it was before the update. Additionally, one dialog was wrongfully changed to be async. This was also reverted back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two dialogs which are expected to block and not return immediately. They are broken since 45bf80f when the code base was updated to JUCE 6.1.0.
Refactoring those to be asynchronous isn't trivial. To keep them working for now
JUCE_MODAL_LOOPS_PERMITTEDis being set to1, like it was before the update.Additionally, one dialog was wrongfully changed to be async. This was also reverted back.