fix(tauri): appimage builds and media loading#850
Open
TastelessVoid wants to merge 5 commits into
Open
Conversation
hazre
requested changes
May 15, 2026
Comment on lines
+32
to
+76
| // AppImage can fail to discover host GStreamer plugins/scanner. Probe | ||
| // common distro layouts, but don't override explicit user config. | ||
| // Not finding these plugings prevents Sable from launching correctly. | ||
| // Maybe there's a better way to do this? | ||
| let plugin_dirs = [ | ||
| "/usr/lib/gstreamer-1.0", | ||
| "/usr/lib64/gstreamer-1.0", | ||
| "/usr/local/lib/gstreamer-1.0", | ||
| "/usr/local/lib64/gstreamer-1.0", | ||
| "/usr/lib/x86_64-linux-gnu/gstreamer-1.0", | ||
| "/usr/lib/aarch64-linux-gnu/gstreamer-1.0", | ||
| "/run/host/usr/lib/gstreamer-1.0", | ||
| "/run/host/usr/lib64/gstreamer-1.0", | ||
| ]; | ||
| let resolved_plugin_dir = plugin_dirs.iter().find(|dir| Path::new(dir).exists()); | ||
|
|
||
| if std::env::var_os("GST_PLUGIN_SYSTEM_PATH_1_0").is_none() { | ||
| if let Some(dir) = resolved_plugin_dir { | ||
| std::env::set_var("GST_PLUGIN_SYSTEM_PATH_1_0", dir); | ||
| } | ||
| } | ||
| if std::env::var_os("GST_PLUGIN_PATH_1_0").is_none() { | ||
| if let Some(dir) = resolved_plugin_dir { | ||
| std::env::set_var("GST_PLUGIN_PATH_1_0", dir); | ||
| } | ||
| } | ||
| if std::env::var_os("GST_PLUGIN_SCANNER").is_none() { | ||
| let mut scanner_candidates: Vec<PathBuf> = vec![ | ||
| PathBuf::from("/usr/lib/gstreamer-1.0/gst-plugin-scanner"), | ||
| PathBuf::from("/usr/lib64/gstreamer-1.0/gst-plugin-scanner"), | ||
| PathBuf::from("/usr/libexec/gstreamer-1.0/gst-plugin-scanner"), | ||
| PathBuf::from("/usr/lib/x86_64-linux-gnu/gstreamer-1.0/gst-plugin-scanner"), | ||
| PathBuf::from("/usr/lib/aarch64-linux-gnu/gstreamer-1.0/gst-plugin-scanner"), | ||
| PathBuf::from("/run/host/usr/lib/gstreamer-1.0/gst-plugin-scanner"), | ||
| PathBuf::from("/run/host/usr/lib64/gstreamer-1.0/gst-plugin-scanner"), | ||
| ]; | ||
|
|
||
| if let Some(path_env) = std::env::var_os("PATH") { | ||
| scanner_candidates.extend(std::env::split_paths(&path_env).map(|p| p.join("gst-plugin-scanner"))); | ||
| } | ||
|
|
||
| if let Some(scanner) = scanner_candidates.iter().find(|path| path.exists()) { | ||
| std::env::set_var("GST_PLUGIN_SCANNER", scanner.as_os_str()); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
instead of this, we should just enable bundleMediaFramework under appimage option. https://v2.tauri.app/distribute/appimage/#multimedia-support-via-gstreamer
| function getCacheRequest(url: string): Request { | ||
| const isAbsoluteHttpUrl = /^https?:\/\//i.test(url); | ||
| if (!isAbsoluteHttpUrl) { | ||
| return new Request(`https://sable-media-cache.invalid/${encodeURIComponent(url)}`); |
Comment on lines
+22
to
+30
| // WebKit2GTK can hit compositor/DMABUF bugs | ||
| // https://github.com/tauri-apps/tauri/issues/14424 | ||
| // https://github.com/tauri-apps/tauri/issues/9394 | ||
| if std::env::var_os("WEBKIT_DISABLE_COMPOSITING_MODE").is_none() { | ||
| std::env::set_var("WEBKIT_DISABLE_COMPOSITING_MODE", "1"); | ||
| } | ||
| if std::env::var_os("WEBKIT_DISABLE_DMABUF_RENDERER").is_none() { | ||
| std::env::set_var("WEBKIT_DISABLE_DMABUF_RENDERER", "1"); | ||
| } |
Member
There was a problem hiding this comment.
This is already handled by __NV_DISABLE_EXPLICIT_SYNC no? what's the exact error/bug here? tauri-apps/tauri#9394 (comment)
hazre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes for the Tauri desktop builds, as well as an attempted fix to media on them. User/Room avatars may potentially not load still, but switching between rooms, closing/opening the member list etc. fixes that.
Also I think I messed up pulling the repo, oops
Type of change
Checklist:
AI disclosure: