IDFM-183: Compounding frequency Calculator - client feedback

[jenbreese]

NOT READY FOR REVIEW

Summary

• Added limits on input fields
• Fixed a couple design issues.
• Added in some fixes to accessibility.
• The requested changes are linked in the ticket to an Excel spreadsheet.
• Need client feedback on several of the requests so not ready to review yet.
  - Ticket

Review By (Date)

• 5/21

Criticality

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Navigate to page
3. Verify there are input limits
4. Verify the percent and dollar amounts are updated per request.

Front End Validation

• Is the markup using the appropriate semantic tags and passes HTML validation?
• Cross-browser testing has been performed?
• Automated accessibility scans performed?
• Manual accessibility tests performed?
• Design is approved by @ user?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

• JIRA ticket(s)
• Other PRs
• Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
• Anyone who should be notified? (@mention them here)

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials