DEV-131471 SDKs - add plaid data points#211
Open
bernardodemelo wants to merge 4 commits into
Open
Conversation
| } | ||
|
|
||
| @Test | ||
| public void testBankWirePlaidScoresGetterAndSetter() { |
Contributor
There was a problem hiding this comment.
Don't think we need this test
| } | ||
|
|
||
| @Test | ||
| public void testBankWirePlaidScoresSerializeWithCorrectStructure() { |
Contributor
There was a problem hiding this comment.
We can merge this with testBankWirePlaidScalarFieldsSerializeWithCorrectKeys above. I don't think we need 2 separate ones since all of BankWire details includes both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Related Issues: DEV-131471
✅ Type of Change
📝 Problem Statement
Merchants using the Java SDK have no way to send Plaid bank account data points to Riskified as part of payment details.
📝 Solution Overview
Extended
BankWirePaymentDetailswith the following optional fields:daysSinceAccountOpeningintdays_since_account_openingdaysWithNegativeBalanceCountintdays_with_negative_balance_countisSavingsOrMoneyMarketAccountbooleanis_savings_or_money_market_accountnsfOverdraftTransactionsCountintnsf_overdraft_transactions_countunauthorizedTransactionsCountintunauthorized_transactions_countplaidScoresPlaidScoresplaid_scoresTwo new model classes were added to support the nested Plaid scores structure:
PlaidScores— holdscustomerInitiatedReturnRiskandbankInitiatedReturnRiskInitiatedReturnRisk— holdsscoreandriskTierSerialization is handled automatically by Gson's
LOWER_CASE_WITH_UNDERSCORESpolicy — no annotations required. All new fields are optional and do not affect existing validation logic.🚨 Risks & Considerations
int,boolean) default to0/falseif not set — Gson will serialize them even when unset. Merchants should only populate fields they have data for.🔍 Additional Notes
.gitignorewas also cleaned up: reorganised into labelled sections, duplicated patterns removed, and.metals/added to prevent Metals LSP artefacts from appearing in PRs.