Fix SMART_EXTRACT_API_HOST env variable for Custom Executor execution#8838
Open
sanjacornelius wants to merge 2 commits into
Open
Fix SMART_EXTRACT_API_HOST env variable for Custom Executor execution#8838sanjacornelius wants to merge 2 commits into
sanjacornelius wants to merge 2 commits into
Conversation
Append SMART_EXTRACT_API_HOST and SMART_EXTRACT_REQUEST_TIMEOUT to the variablesParameter in ProcessMaker/ScriptRunners/Base.php. The change injects smart-extract.api_host and smart-extract.request_timeout from configuration so script runners receive the Smart Extract service host and request timeout values at runtime.
Contributor
|
QA server K8S was successfully deployed https://ci-6e7b2eafd7.engk8s.processmaker.net |
eiresendez
approved these changes
May 20, 2026
Contributor
eiresendez
left a comment
eiresendez
left a comment
There was a problem hiding this comment.
Approved. The change works! Please consider addressing the review comment if you consider it critical 👍
Include SMART_EXTRACT_API_HOST and SMART_EXTRACT_REQUEST_TIMEOUT inside both the escaped and non-escaped branches when building variablesParameter so they are properly escaped when $useEscape is true. Remove the duplicated lines that were appended outside the conditional. This ensures SMART_EXTRACT settings are consistently included alongside HOST_URL.
|
Contributor
|
QA server K8S was successfully deployed https://ci-6e7b2eafd7.engk8s.processmaker.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the SMART_EXTRACT_API_HOST environment variable was not being properly returned when CUSTOM_EXECUTOR was enabled and SCRIPT_MICROSERVICE was disabled.
The fix ensures that the SMART_EXTRACT_API_HOST environment variable is correctly injected and available regardless of which executor configuration is being used.
Root Cause
The environment variable was only being properly configured for Script Microservice execution paths. When running scripts through the Custom Executor with the Script Microservice disabled, the variable was not available within the execution environment.
Solution
Updated the environment variable handling to ensure
SMART_EXTRACT_API_HOSTis consistently available for both:How to Test
getenv('SMART_EXTRACT_API_HOST')Related Tickets & Packages
ci:deploy
ci:package-smart-extract:task/FOUR-31337
Code Review Checklist