Buy similar: fix mod matching and improve search workflow#9857
Open
vaisest wants to merge 10 commits into
Open
Buy similar: fix mod matching and improve search workflow#9857vaisest wants to merge 10 commits into
vaisest wants to merge 10 commits into
Conversation
vaisest
force-pushed
the
comparison-tab-market-search-fixes
branch
from
68e4750 to
a3c464b
Compare
The file contains both explicit unique mods, and implicit mods that only spawn on some bases. Implicit is very misleading.
- add ids to cluster jewel types (trade site uses these for the dropdown) - combine comparison trade and droptimizer trade utility to TradeHelpers.lua - export foulborn jewel mods - remove ModImplicit.lua. It was misleading and equal to ModItemExlclusive.lua - export "adds # passive skills" mod. GGG stat values incorrectly say 0-0 which hid it.
…tional in dev too
vaisest
changed the title
Contributor
Author
|
Notably, crucible mods aren't matched. This probably doesn't matter much because standard, but regardless in the future it can be added once there's an easier way to match mods. The trade site specifically matches against crucible mods, and not just single stats |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Primary function was to fix many mods not working in the "buy similar" menu, which kind of enables the tool to work. Many e.g. local mods matched to global mods, which meant searching for armour or weapons was fairly difficult. Inversed mods were also not correctly matched.
Some of the workflow steps were also somewhat pointless, and were streamlined. Namely, the edit box is gone, and clicking things on or off automatically regenerates the link. The button copies and opens the url. Mods with no stat values also no longer have min and max edit boxes.
There are also more colours in the menu, and items have gaps.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/mFd6odfh1yun (has many items and some that use dropdowns on the trade site.
Before screenshot:
After screenshot: