Skip to content

Export trade hashes for mod stats#9853

Merged
LocalIdentity merged 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:trade-hash-exports
May 17, 2026
Merged

Export trade hashes for mod stats#9853
LocalIdentity merged 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:trade-hash-exports

Conversation

@vaisest
Copy link
Copy Markdown
Contributor

@vaisest vaisest commented May 14, 2026

Fixes nothing. This is not necessarily required for anything currently, and is mostly informative

Description of the problem being solved:

Adds trade hash exports to mod exports, and refactor mods.lua. The latter mostly motivated by LuaJIT issues where loading modules which contain very large tables crashes the program. Data files are now split into much more specific categories, and are combined at runtime to data.itemMods.Item.

Steps taken to verify a working solution:

  • Manually checked quite a few random mods from multiple categories. They seem to be correct, and don't overlap with other files for no reason (e.g. ModExplicit doesn't have delve mods).
  • Ran tests
  • Regenerated modcache and verified there are no changes

Exported mods now have a field tradeHashes which is a table that maps from a trade hash to the matched modline for each stat. Note that there can be multiple of these, if a mod has multiple stats (i.e. lines) to it.

I wasn't able to find incorrect hashes, except for uul-netol's attack bleed chance. It doesn't really make sense since it's a single stat mod. Not sure what is going on there.

Outside of that everything seemed correct, except for obvious ones like timeless jewel mods (they have a special pseudo stat key).

@vaisest vaisest marked this pull request as draft May 14, 2026 23:23
@vaisest vaisest marked this pull request as ready for review May 15, 2026 22:33
@LocalIdentity LocalIdentity added the technical Hidden from release notes label May 17, 2026
@LocalIdentity LocalIdentity merged commit 0b6e7a9 into PathOfBuildingCommunity:dev May 17, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Hidden from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants