Export trade hashes for mod stats#9853
Merged
LocalIdentity merged 5 commits intoMay 17, 2026
Merged
Conversation
…orrupted, and delve files
LocalIdentity
approved these changes
May 17, 2026
0b6e7a9
into
PathOfBuildingCommunity:dev
3 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes nothing. This is not necessarily required for anything currently, and is mostly informative
Description of the problem being solved:
Adds trade hash exports to mod exports, and refactor mods.lua. The latter mostly motivated by LuaJIT issues where loading modules which contain very large tables crashes the program. Data files are now split into much more specific categories, and are combined at runtime to
data.itemMods.Item.Steps taken to verify a working solution:
Exported mods now have a field
tradeHasheswhich is a table that maps from a trade hash to the matched modline for each stat. Note that there can be multiple of these, if a mod has multiple stats (i.e. lines) to it.I wasn't able to find incorrect hashes, except for uul-netol's attack bleed chance. It doesn't really make sense since it's a single stat mod. Not sure what is going on there.
Outside of that everything seemed correct, except for obvious ones like timeless jewel mods (they have a special pseudo stat key).