Apply Infernal Cry extra fire to empowered attacks#1911
Open
unrealdreamz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #714
Adds the missing stat mapping for Infernal Cry's empowered attack bonus so its
Gain x% of Damage as Extra Fire Damagestat is emitted as a Warcry buff for empowered melee attacks.Root Cause
Infernal Cry's exported skill data already included
infernal_cry_exerted_attack_all_damage_%_to_gain_as_fire_%, and the stat description rendered it for users, but the skill had nostatMapentry. The stat therefore never became a live modifier, so enabling Infernal Cry could show no extra fire damage effect on empowered melee attacks.This PR intentionally does not claim to finish the broader automatic Full DPS / Warcry Power behavior discussed in #714; it fixes the missing damage modifier path only.
Fix
statMapentry for Infernal Cry.DamageGainAsFireas a melee-only Warcry global effect.Empoweredcondition so non-empowered attacks are not affected.Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '714 Infernal Cry empowered fire' --json number,title,headRefName,author,url --jq '.'->[]git diff --check-> passedgit diff --cached --check-> passedgit show --check --stat --oneline HEAD-> passedI did not run Docker/Busted locally in this pass because this machine is currently in active foreground use; the regression is included for CI to run in the repository's normal test container.
Risk / Rollback
Low risk. The change is data-scoped to Infernal Cry and applies only when the active skill is an empowered melee attack. Rollback is reverting this commit, which removes the stat mapping and the regression test.