Typed fixed vector#737
Open
wvpm wants to merge 1 commit into
Open
Conversation
wvpm
force-pushed
the
typed_fixed_vector
branch
5 times, most recently
from
4e64a63 to
3564f97
Compare
Spartan322
reviewed
May 16, 2026
Spartan322
reviewed
May 16, 2026
Spartan322
reviewed
May 16, 2026
Spartan322
reviewed
May 19, 2026
Spartan322
reviewed
May 19, 2026
Spartan322
reviewed
May 19, 2026
| forwardable_span<const ReformGroup> reforms; | ||
| forwardable_span<const RegimentType> regiment_types; | ||
| forwardable_span<const ShipType> ship_types; | ||
| memory::vector<RegimentType> const& regiment_types; //can't use forwardable_span due to macos |
Contributor
Author
There was a problem hiding this comment.
It would complain during the pipeline about not knowing the size of UnitInstanceBranched<unit_branch_t::LAND>.
So I have to pass it as a vector reference instead of a span :(
Member
There was a problem hiding this comment.
Something is wrong if the forwardable_span isn't supporting forwarding for its particular target case.
Contributor
Author
There was a problem hiding this comment.
I think it's due to UnitInstanceBranched being a template.
I gave up on try-compile via pipeline. This is a quick fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.