Implement reference view to group by source#23
Open
jamlung-ri wants to merge 2 commits into
Open
Conversation
snyaggarwal
reviewed
May 18, 2026
Contributor
snyaggarwal
left a comment
snyaggarwal
left a comment
There was a problem hiding this comment.
there is a lot of logic for color, not sure whats the goal to have out of theme colors, but I think thats not needed.
Contributor
There was a problem hiding this comment.
this should be in src/components/references/
|
|
||
| const getSourceColorKey = source => [source?.owner, source?.id || source?.short_code].filter(Boolean).join('/') | ||
|
|
||
| const parseSourceFromExpression = expression => { |
Contributor
There was a problem hiding this comment.
this is almost duplicate of core.common.utils.URIToParentParams
| return label || '-' | ||
| } | ||
|
|
||
| const hashString = value => { |
Contributor
There was a problem hiding this comment.
this should be core/common/utils.js
| import MoreVertIcon from '@mui/icons-material/MoreVert' | ||
| import RepoChip from '../repos/RepoChip' | ||
|
|
||
| const SOURCE_COLORS = [ |
Contributor
There was a problem hiding this comment.
these colors needs to be defined in src/common/color.js
and are they from theme?
- Move component from search/ to references/ directory - Move SOURCE_COLORS to src/common/colors.jsx using theme palette colors (primary/secondary/tertiary) - Move hashString to src/common/utils.js - Refactor parseSourceFromExpression to use existing URIToParentParams utility Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
Thanks @snyaggarwal, I addressed those comments and committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes OpenConceptLab/ocl_issues#2508