[19.0] [MIG] contract: Migration to 19.0#1312
Open
BhaveshHeliconia wants to merge 271 commits into
Open
Conversation
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
from
877c2f7 to
8f589c2
Compare
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
2 times, most recently
from
b18f362 to
885e5a6
Compare
|
@BhaveshHeliconia can you please handle the failing tests so we can push this forward? |
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
5 times, most recently
from
a38846e to
c99f54f
Compare
Member
|
@BhaveshHeliconia could you please re-run the CI checks? |
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
from
c99f54f to
983c9c2
Compare
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
2 times, most recently
from
a653227 to
3251a90
Compare
Contributor
Author
Member
|
/ocabot migration contract Please cherry-pick #1343 |
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
from
3251a90 to
a3218c0
Compare
Contributor
Author
@pedrobaeza : Done. Thanks! |
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
from
a3218c0 to
b57bad9
Compare
pedrobaeza
reviewed
Nov 20, 2025
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
2 times, most recently
from
65801a9 to
4ce03c5
Compare
Contributor
Author
|
@pedrobaeza : I’ve completed all the changes you recommended. Thanks for the feedback! |
pedrobaeza
reviewed
Nov 21, 2025
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
2 times, most recently
from
b527c46 to
4e377c2
Compare
Member
|
Please include #1341 |
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
from
4e377c2 to
8cddba3
Compare
Contributor
Author
Done. Thanks! |
…ing onchanges When copying values from the contract template, skip assignment if the value is already the same on the contract. This prevents triggering unnecessary onchanges without altering the behavior.
We should add a validation of company as it might collide if we have multiple companies installed and this companies have a sequence.
Currently translated at 96.8% (248 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/ca/
…ct lines This field is unused in this module, but in the contract_sale_invoicing module it is used to search Sales Orders. However, many times this field goes unnoticed and users set the analytic distribution directly on the lines. After this commit, the field is computed automatically based on the contract lines.
… does not have access TT59505
…ontract line Adding analytic.mixin on a model adds the analytic_distribution compute field In the mixin the compute is not implemented, letting the method being implemented in each concrete model. This wasn't done yet for contract line. Before this commit: adding a product to a contract line didn't fill the analytic distribution. After this commit: adding a product to a contract line triggers the compute method (similarly to the one on sale order lines), evaluating the account analytic distribution models and setting the correct analytic distribution
On portal, the cancelled lines are not distinguished from running ones, as the next invoice date is still displayed, and the color is the same (on contrary than the backend, that appears greyed). So let's do something similar in portal: - Put the row as grey. - Hide the nexte invoice date on that case. TT59704
Currently translated at 100.0% (258 of 258 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/fr/
This field slightly degrades performance. We don't need to maintain retro-compatibility with 11- anymore.
Currently translated at 6.6% (17 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/sl/
Currently translated at 96.4% (247 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/ca/
Allow to hook contract._prepare_invoice to add more invoice lines
Fix date_ref when invoicing multiple contracts
Currently translated at 92.5% (237 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/es/
BhaveshHeliconia
force-pushed
the
19.0-mig-contract
branch
from
37344dd to
82bd234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.