[nightshift] ci-fixes: align Go version, add permissions, fix gofmt#38
Closed
nightshift-micr wants to merge 1 commit into
Closed
[nightshift] ci-fixes: align Go version, add permissions, fix gofmt#38nightshift-micr wants to merge 1 commit into
nightshift-micr wants to merge 1 commit into
Conversation
…s, fix gofmt - Fix Go version mismatch: ci.yml and release.yml used 1.22 while go.mod requires 1.25.6 and live-e2e.yml already uses 1.25.6 - Add explicit permissions: contents: read to ci.yml for least-privilege - Simplify gofmt check: use 'gofmt -l .' instead of find subshell [nightshift ci-fixes]
Owner
|
Superseded by #43, which merged the CI Go-version alignment, workflow permissions, and gofmt update onto main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nightshift: ci-fixes
Changes
Go version alignment (critical)
ci.ymlandrelease.ymlusedgo-version: "1.22"whilego.modrequiresgo 1.25.6live-e2e.ymlalready used the correct version — this was an inconsistencygo-version: "1.25.6"to matchgo.modPermissions hardening
permissions: contents: readtoci.ymlfor least-privilege principlegofmt check fix
gofmt -l $(find . -name '*.go' -type f)togofmt -l .gofmt -l .handles this nativelyFiles Changed
.github/workflows/ci.yml— Go version, permissions, gofmt.github/workflows/release.yml— Go versionVerification
permissionsblock follows GitHub security best practicesgofmt -l .is the idiomatic approach