[nightshift] api-contract-verify: fix GUI API contract issues#27
Closed
nightshift-micr wants to merge 1 commit into
Closed
[nightshift] api-contract-verify: fix GUI API contract issues#27nightshift-micr wants to merge 1 commit into
nightshift-micr wants to merge 1 commit into
Conversation
Owner
|
Superseded by #43, which merged the remaining actionable API-contract and GUI validation fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by Nightshift v3 (GLM 5.1).
Task: api-contract-verify
Category: pr
Changes: Fix GUI API contract issues in
/api/enrollendpointFindings & Fixes
/api/enrollresponse includesnullforexpiresAton session/permanent leases (Fixed)map[string]any{"expiresAt": rec.ExpiresAt}which serializes as"expiresAt": nullfor nil pointers, even thoughLeaseRecordusesomitempty.expiresAtin the response when it's non-nil.Missing validation for timed mode with zero days (Fixed)
/api/enrollendpoint accepted{"mode":"timed","days":0}without error, deferring toParseDurationDayswhich rejects it. However, the GUI should validate this early with a clear error message.EnrollFn.presetSummaryomitsStableVersionOverride(Documented, not fixed)/api/presetsresponse doesn't includestableVersionOverride. This is a minor contract gap — the frontend can't display whether a preset pins to a specific version. Not fixed as it requires frontend changes.enrollRequestdoesn't mapNonInteractive(Documented, not fixed)NonInteractiveis not part of the request schema. This is correct behavior, documented for completeness.Merge if useful, close if not.