Add admin panel enhancements according to #3283#618
Open
xkello wants to merge 3 commits into
Open
Conversation
Coverage Report for CI Build 25925095565Coverage increased (+0.1%) to 93.248%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions175 previously-covered lines in 13 files lost coverage.
Coverage Stats
💛 - Coveralls |
MarcelGeo
requested changes
May 18, 2026
| * Call setFetchFn() immediately after setup to register the table-specific | ||
| * fetch action; all event handlers will invoke it automatically. | ||
| */ | ||
| export function useDataTableSearch(opts: DataTableSearchOptions = {}) { |
Collaborator
There was a problem hiding this comment.
It's not better to add here also watcher for route query params?
| const query: Record<string, string> = {} | ||
| if (search.value) query.q = search.value | ||
| if (options.page > 1) query.page = String(options.page) | ||
| if (options.itemsPerPage !== 20) |
Collaborator
There was a problem hiding this comment.
some hardcoded constant? I think we can add it to options too with default 20
| <PColumn field="active" header="Active"> | ||
| <template #body="{ data }"> | ||
| <router-link :to="accountRoute(data)" class="dt-row-link"> | ||
| <i v-if="data.active" class="ti ti-check" /> |
Collaborator
There was a problem hiding this comment.
Just note from some users. We could add here just text Active / Inactive as icon is not copy able.
| @sort="onSort" | ||
| data-cy="accounts-table" | ||
| > | ||
| <template v-for="header in headers" :key="header.field"> |
Collaborator
There was a problem hiding this comment.
This means also for other tables. We could probably live with this config json as we can then extend it and have one default column when slot is not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functionality according to https://github.com/MerginMaps/server-private/issues/3283.