github-integration#44
Open
Makisuo wants to merge 1 commit into
Open
Conversation
|
This run croaked 😵 The workflow encountered an error before any progress could be reported. Please check the link below for details. |
Ingest Rust Test + Benchmark ResultsCommit: Load Benchmark —
|
| Metric | main (median) | PR (median) | Delta |
|---|---|---|---|
| Requests/sec | 3039.12 | 2810.55 | -7.5% worse |
| Rows/sec | 30391.17 | 28105.54 | -7.5% worse |
| p50 latency | 20.63 ms | 21.66 ms | +5.0% worse |
| p95 latency | 39.89 ms | 29.54 ms | -25.9% better |
| p99 latency | 42.77 ms | 42.06 ms | -1.6% better |
| Export catch-up | 0.026 s | 0.026 s | +0.4% worse |
| Max RSS | 97.59 MiB | 96.96 MiB | -0.6% better |
| Failures | 0 | 0 | same |
Same code path on both sides (same LOAD_TEST_INGEST_MODE), so the delta column is meaningful. Numbers come from ubuntu-latest, which is noisy — treat single-digit-percent deltas as noise.
PR load benchmark JSON (per-iteration)
[
{
"ingest_mode": "tinybird",
"requests": 2000,
"successes": 2000,
"failures": 0,
"rows_sent": 20000,
"rows_exported": 20000,
"imports": 22,
"duration_seconds": 0.79578394,
"export_catchup_seconds": 0.026213044,
"request_rps": 2513.2449895885056,
"row_rps": 25132.449895885056,
"p50_ms": 24.325,
"p95_ms": 31.262,
"p99_ms": 40.258,
"max_rss_mb": 94.953125,
"max_cpu_percent": 80.3,
"avg_cpu_percent": 48.45
},
{
"ingest_mode": "tinybird",
"requests": 2000,
"successes": 2000,
"failures": 0,
"rows_sent": 20000,
"rows_exported": 20000,
"imports": 21,
"duration_seconds": 0.71160348,
"export_catchup_seconds": 0.025852751,
"request_rps": 2810.5539899832984,
"row_rps": 28105.53989983298,
"p50_ms": 21.663,
"p95_ms": 29.539,
"p99_ms": 43.284,
"max_rss_mb": 98.06640625,
"max_cpu_percent": 87.5,
"avg_cpu_percent": 68.75
},
{
"ingest_mode": "tinybird",
"requests": 2000,
"successes": 2000,
"failures": 0,
"rows_sent": 20000,
"rows_exported": 20000,
"imports": 23,
"duration_seconds": 0.670553449,
"export_catchup_seconds": 0.02607498,
"request_rps": 2982.6108611962413,
"row_rps": 29826.108611962412,
"p50_ms": 20.966,
"p95_ms": 25.01,
"p99_ms": 42.061,
"max_rss_mb": 96.9609375,
"max_cpu_percent": 89.4,
"avg_cpu_percent": 51.800000000000004
}
]main load benchmark JSON (per-iteration)
[
{
"ingest_mode": "tinybird",
"requests": 2000,
"successes": 2000,
"failures": 0,
"rows_sent": 20000,
"rows_exported": 20000,
"imports": 25,
"duration_seconds": 0.726309487,
"export_catchup_seconds": 0.0256486,
"request_rps": 2753.647082679508,
"row_rps": 27536.47082679508,
"p50_ms": 22.6,
"p95_ms": 25.12,
"p99_ms": 45.806,
"max_rss_mb": 97.375,
"max_cpu_percent": 87.5,
"avg_cpu_percent": 52.05
},
{
"ingest_mode": "tinybird",
"requests": 2000,
"successes": 2000,
"failures": 0,
"rows_sent": 20000,
"rows_exported": 20000,
"imports": 21,
"duration_seconds": 0.648065982,
"export_catchup_seconds": 0.027002631,
"request_rps": 3086.1055132500383,
"row_rps": 30861.055132500383,
"p50_ms": 20.236,
"p95_ms": 39.886,
"p99_ms": 42.218,
"max_rss_mb": 97.5859375,
"max_cpu_percent": 94.6,
"avg_cpu_percent": 55.599999999999994
},
{
"ingest_mode": "tinybird",
"requests": 2000,
"successes": 2000,
"failures": 0,
"rows_sent": 20000,
"rows_exported": 20000,
"imports": 21,
"duration_seconds": 0.658085915,
"export_catchup_seconds": 0.025968812,
"request_rps": 3039.1168606001847,
"row_rps": 30391.168606001847,
"p50_ms": 20.629,
"p95_ms": 40.201,
"p99_ms": 42.766,
"max_rss_mb": 101.6171875,
"max_cpu_percent": 92.8,
"avg_cpu_percent": 46.4
}
]WAL-acked microbench (cargo bench --bench ingest_bench)
Compiling maple-ingest v0.1.0 (/home/runner/work/maple/maple/apps/ingest)
Finished `bench` profile [optimized] target(s) in 30.89s
Running benches/ingest_bench.rs (target/release/deps/ingest_bench-12226c7892c2c0cd)
Gnuplot not found, using plotters backend
test ingest_accept/logs_10_rows_wal_ack ... bench: 384112 ns/iter (+/- 34310)
test ingest_accept/traces_10_spans_wal_ack ... bench: 414998 ns/iter (+/- 25354)
cargo test
Updating crates.io index
Compiling maple-ingest v0.1.0 (/home/runner/work/maple/maple/apps/ingest)
Finished `test` profile [unoptimized + debuginfo] target(s) in 7.93s
Running unittests src/lib.rs (target/debug/deps/maple_ingest-ed3692bd2d4d62b8)
running 21 tests
test otel::tests::build_resource_sets_runtime_and_sdk_type ... ok
test telemetry::tests::hex_empty_for_zero_ids ... ok
test telemetry::tests::log_encoder_matches_tinybird_row_shape ... ok
test telemetry::tests::logs_emit_exactly_the_jsonpaths_declared_in_datasources_ts ... ok
test telemetry::tests::logs_severity_text_falls_back_to_mapped_number ... ok
test telemetry::tests::custom_datasource_names_propagate_to_frames ... ok
test telemetry::tests::logs_use_observed_time_when_time_unix_nano_is_zero ... ok
test telemetry::tests::metrics_summary_data_points_are_dropped ... ok
test telemetry::tests::metric_encoder_matches_all_tinybird_datasource_shapes ... ok
test telemetry::tests::metrics_emit_exactly_the_jsonpaths_declared_in_datasources_ts ... ok
test telemetry::tests::sampling_keeps_errors_even_when_ratio_low ... ok
test telemetry::tests::timestamp_has_nano_precision ... ok
test telemetry::tests::timestamps_match_clickhouse_datetime64_nine_format ... ok
test telemetry::tests::trace_encoder_matches_tinybird_row_shape ... ok
test telemetry::tests::traces_emit_exactly_the_jsonpaths_declared_in_datasources_ts ... ok
test telemetry::tests::wal_partial_drain_advances_cursor_without_truncating ... ok
test telemetry::tests::wal_round_trips_frame ... ok
test telemetry::tests::wal_truncates_after_full_drain_allowing_further_appends ... ok
test telemetry::tests::pipeline_e2e_exports_traces_to_fake_tinybird ... ok
test telemetry::tests::pipeline_e2e_exports_metrics_to_fake_tinybird ... ok
test telemetry::tests::pipeline_e2e_exports_gzip_ndjson_to_fake_tinybird ... ok
test result: ok. 21 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.10s
Running unittests src/bin/load_test.rs (target/debug/deps/load_test-2400d1bca3e1f791)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/main.rs (target/debug/deps/maple_ingest-d6da5bec54f731c7)
running 18 tests
test tests::cloudflare_ndjson_payload_parses_multiple_records ... ok
test tests::cloudflare_log_record_maps_body_severity_and_attributes ... ok
test tests::cloudflare_timestamps_support_rfc3339_unix_and_unix_nano ... ok
test tests::cloudflare_validation_payload_is_detected ... ok
test tests::d1_truthy_accepts_int_and_bool_self_managed ... ok
test tests::enrichment_overwrites_tenant_fields ... ok
test tests::d1_response_parses_empty_results_as_no_match ... ok
test tests::d1_response_parses_failure_with_errors ... ok
test tests::d1_response_parses_success_with_rows ... ok
test tests::extract_ingest_key_returns_sentinel_literal_unchanged ... ok
test tests::hash_is_deterministic ... ok
test tests::non_self_managed_goes_to_shared_pool ... ok
test tests::resolve_ingest_key_returns_none_when_hash_missing ... ok
test tests::resolve_ingest_key_returns_self_managed_false_when_no_settings_row ... ok
test tests::self_managed_degrades_to_shared_when_endpoint_unset ... ok
test tests::self_managed_goes_to_self_managed_pool_when_configured ... ok
test tests::sentinel_token_matches_only_exact_literal ... ok
test tests::resolve_ingest_key_returns_self_managed_true_when_active_settings_row ... ok
test result: ok. 18 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
Doc-tests maple_ingest
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.