Skip to content

Add test for recent pr #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LossyDragon merged 1 commit into from
Apr 29, 2026
Merged

Add test for recent pr #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/in/dragonbra/javasteam/steam/cdn/Client.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ class Client(steamClient: SteamClient) : Closeable {

private val logger: Logger = LogManager.getLogger(Client::class.java)

private fun buildCommand(
@JvmStatic
fun buildCommand(
server: Server,
command: String,
query: String? = null,
Expand Down
17 changes: 17 additions & 0 deletions src/test/java/in/dragonbra/javasteam/steam/cdn/CDNClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,4 +176,21 @@ public void testPrivateIPv6Addresses(String ipAddress, boolean expected) throws
boolean result = ClientLancache.isPrivateAddress(address);
Assertions.assertEquals(expected, result);
}

@ParameterizedTest
@CsvSource({
"token=abc, token, ", // normal, no change
"?token=abc, token, ?token", // leading ? stripped
"??token=abc, token, ??token", // multiple leading ? stripped
"?token=abc&foo=bar, token, ?token", // leading ? with multiple params
})
public void buildCommandStripsLeadingQuestionMarkFromQueryString(String query, String expectedKey, String unexpectedKey) {
var server = Server.fromHostAndPort("localhost", 80);
HttpUrl url = Client.buildCommand(server, "depot/731/manifest", query, null);

Assertions.assertNotNull(url.queryParameter(expectedKey));
if (unexpectedKey != null) {
Assertions.assertNull(url.queryParameter(unexpectedKey));
}
}
}
Loading