Don't allow datasets to be created from regex capture groups.#7668
Merged
Conversation
labkey-klum
requested review from
a team and
labkey-danield
and removed request for
a team and
labkey-danield
labkey-adam
approved these changes
May 18, 2026
Contributor
labkey-adam
left a comment
labkey-adam
left a comment
There was a problem hiding this comment.
Should we add a test?
Contributor
Author
|
Yes, it's here: https://github.com/LabKey/premiumModules/pull/562 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
tracking issue : https://github.com/LabKey/internal-issues/issues/905
This change implements the desired behavior for the
nameoridcapture groups for a dataset file watcher. In either case if the name or id can't be resolved to an existing dataset, we want to error out. Currently, the behavior is that a new dataset with a name of either thenameoridvalue gets created.This change is intended to bring the file watcher into alignment with the sample type file watcher.