Override editUIButtonHandler to set showImport=false#699
Merged
labkey-martyp merged 1 commit intoMay 18, 2026
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
labkey-bpatel
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The base
EHR.Utils.editUIButtonHandlerpassesshowImport: trueto/ehr/updateQuery, which surfaces a bulk-import affordance on the editview. That path lets users insert/update records without going through
the EHR data-entry forms and without an admin permission gate. This PR
buttons up that path in the NIRC deployment.
Changes
EHR.Utils.editUIButtonHandlerinnirc_ehr/resources/web/nirc_ehr/nircOverrides.jsto passshowImport: falsewhile delegating to the baseEHR.Utils.editUIButtonCore. The override piggybacks on NIRC'sexisting
nircOverrides.js, already registered as an EHR clientdependency in
NIRC_EHRModule.java. No changes to the baseehrmodule.