Accessibility improvements: Keyboard interactions#2003
Open
cnathe wants to merge 78 commits into
Open
Conversation
…nd ESCAPE to close
…able-text styling for actionable elements
This was referenced May 14, 2026
…ts with onKeyDown and other usages
labkey-nicka
approved these changes
May 18, 2026
|
|
||
| useEffect(() => { | ||
| // Focus the modal on open so keyboard navigation starts within it rather than behind it | ||
| modalRef.current?.focus(); |
Contributor
There was a problem hiding this comment.
Please verify this behavior doesn't override the focus done in the Expression Assistant focus into the prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds keyboard accessibility in several parts of the @labkey/components package. It converts non-interactive elements (
<span>,<div>,<a>) with onClick handlers into proper<button>elements, adds focus trapping andEscape-to-close behavior to modals, makes editable grid cells tab-focusable, and extends
useEnterEscapeto pass the keyboard event to callbacks. Several class components are refactored to functional components along the way.Related Pull Requests
Changes
useEnterEscapeto allow optional event argument to callbacks and to allow for multi-select behaviorAttachmentCardso input field is not hiddentabIndexandonKeyDowncallback for thread components